[#DWR-375] create all DWR threads as daemon threads - DWR

Details

Type: Improvement
Status: Resolved
Priority: Normal
Resolution: Fixed
Affects Version/s: 2.0.5, 3.0.RC1
Fix Version/s: None
Component/s: Core

Documentation Required:
No

Description:

Hide
All DWR threads should create a daemon threads. The JVM might not exit till all non-daemon threads are dead (http://java.sun.com/j2se/1.5.0/docs/api/java/lang/Thread.html). Starting threads this way should cut down on all the servlet hackery. When using ScheduledThreadPoolExecutor you just need to pass the ThreadFactory below to the constructor in order to have it create a daemon thread.

public class DaemonThreadFactory implements ThreadFactory {

      public Thread newThread(Runnable r) {
        Thread t = new Thread(r);
        t.setDaemon(true);
        return t;
      }

}

Show
All DWR threads should create a daemon threads. The JVM might not exit till all non-daemon threads are dead (http://java.sun.com/j2se/1.5.0/docs/api/java/lang/Thread.html). Starting threads this way should cut down on all the servlet hackery. When using ScheduledThreadPoolExecutor you just need to pass the ThreadFactory below to the constructor in order to have it create a daemon thread. public class DaemonThreadFactory implements ThreadFactory {       public Thread newThread(Runnable r) {         Thread t = new Thread(r);         t.setDaemon(true);         return t;       } }

Issue Links

Duplicate

This issue is duplicated by:
~~DWR-281~~ Tomcat does not shutdown because on non-daemon threads

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

David Marginian added a comment - 25/Apr/09 6:07 AM

DWR currently creates an AutoShutdownScheduledThreadPoolExecutor which is supposed to (and probably is - since tomcat is shutting down properly) taking care of the proper destruction of all threads - if the DwrListener is registered.

My thinking here is that we can get rid of this code if we use the code recommended by Deno. Thoughts?

Show

David Marginian added a comment - 25/Apr/09 6:07 AM DWR currently creates an AutoShutdownScheduledThreadPoolExecutor which is supposed to (and probably is - since tomcat is shutting down properly) taking care of the proper destruction of all threads - if the DwrListener is registered. My thinking here is that we can get rid of this code if we use the code recommended by Deno. Thoughts?

Hide

Permalink

Mike Wilson added a comment - 25/Apr/09 11:28 AM

I think we should definitiely try "daemon" out. Having user code not need to add an additional listener in web.xml would be great. Deno is spot on with the ThreadFactory example above.

Show

Mike Wilson added a comment - 25/Apr/09 11:28 AM I think we should definitiely try "daemon" out. Having user code not need to add an additional listener in web.xml would be great. Deno is spot on with the ThreadFactory example above.

Hide

Permalink

David Marginian added a comment - 28/Apr/09 2:21 AM

I have implemented the daemon thread factory and removed all existing shutdown code (previously used to kill threads). Ready for testing.

Show

David Marginian added a comment - 28/Apr/09 2:21 AM I have implemented the daemon thread factory and removed all existing shutdown code (previously used to kill threads). Ready for testing.

DWR

create all DWR threads as daemon threads

Details

Issue Links

Activity

People

Dates