DWR

Tomcat 6 Comet Support - TomcatContainerAbstraction not native

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Normal Normal
  • Resolution: Fixed
  • Affects Version/s: 3.0.RC1
  • Fix Version/s: 3.0.RC2
  • Component/s: Core
  • Documentation Required:
    No
  • Description:
    Hide
    Hello there,

    I think there is a small bug in DwrCometProcessor. I tried to implement it in Tomcat 6.0.18 and the service() method called in
    event(...) always blocks.

    The problem is that while looping through the different ContainerAbstraction´s it does not use the TomcatContainerAbstraction
    but the normal Servlet2ContainerAbstraction. This blocks the thread and waits for more data.

    The reason for that is simple: You check in TomcatContainerAbstraction#isNativeEnvironment for the Servlet Attribute "ATTRIBUTE_ENABLED"
    which is not set at that moment! In DwrCometProcessor.java you have to swap line 40 with line 44.

    After that everything should work fine.

    Greets,
    daniel
    Show
    Hello there, I think there is a small bug in DwrCometProcessor. I tried to implement it in Tomcat 6.0.18 and the service() method called in event(...) always blocks. The problem is that while looping through the different ContainerAbstraction´s it does not use the TomcatContainerAbstraction but the normal Servlet2ContainerAbstraction. This blocks the thread and waits for more data. The reason for that is simple: You check in TomcatContainerAbstraction#isNativeEnvironment for the Servlet Attribute "ATTRIBUTE_ENABLED" which is not set at that moment! In DwrCometProcessor.java you have to swap line 40 with line 44. After that everything should work fine. Greets, daniel

Activity

Hide
David Marginian added a comment - 21/Oct/09 5:04 PM

Your fix is right on. I have implemented it.

Show
David Marginian added a comment - 21/Oct/09 5:04 PM Your fix is right on. I have implemented it.

People

Dates

  • Created:
    13/Oct/09 11:09 AM
    Updated:
    21/Oct/09 5:05 PM
    Resolved:
    21/Oct/09 5:05 PM